Adds 2 new IOK rules for Santander kits #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradleyjkemp
approved these changes
Aug 10, 2022
| requests|contains: '?v=1655293257536' | ||
|
|
||
| usernameLabelID: | ||
| html|contains: '47563B2825160654ADB2CC97CE152AF3' |
There was a problem hiding this comment.
This is a good example of where #38 could be problematic. For these sites the HTML and DOM are very different
The HTML is the static stuff loaded from the server whereas it seems this kit builds most of the page dynamically using JS.
Let's add this rule for now, but I'll keep a note to update it once we've got DOM support
There was a problem hiding this comment.
I'm not sure this kit is dynamically generated by JS as you have suggested, I see nothing to indicate such behaviour. Also managed to see why the 2nd reference did not flag, it is because the username & password label IDs are not present in the DOM, will adjust the rule accordingly now.
IlluminatiFish
added a commit
to IlluminatiFish/IOK
that referenced
this pull request
Aug 10, 2022
Fixes issue identified in phish-report#55 (comment)
bradleyjkemp
pushed a commit
that referenced
this pull request
Aug 10, 2022
Fix rule Fixes issue identified in #55 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 new IOK rules for Santander, targeting Spanish speaking users.